ChadFibke
commented
5 years ago Also:
- No need for using redundant code. Your summary command already tells you the max and min fertility, which you recalculated later. No need to do more work!
Open ChadFibke opened 5 years ago
ChadFibke
commented
5 years ago Also:
The README
Creativity & Effort
The good :thumbsup:
Needs work :thumbsdown:
Ease of access
The good :thumbsup:
Needs work :thumbsdown:
For next time: try linking and listing your homework (md/rmd files) in the readme to help with navigation. That way, I can land on your repo, and click right on the files I want to see. Again, this will help with more complex repos in the future!
You have several unnecessary files, which will overwhelm readers as the repo grows! You can keep the reflection.log/md, and instructions, but please make a sub folder for these in your repo.
The Rmd/md
Coding style/strategy
The good :thumbsup:
Explored a new data set!.
Moderate markdown syntax used.
Needs work :thumbsdown:
Make sure to use Headers, inline, and code chunk comments. I usually use headers for more structure. I will use in line comments to tell the reader the general idea of that I'm doing with the code in the following code chunk, and to interpret the output (usually just in point form). I will then use code chunk comments to explain particular arguments in my code. This will help with the flow and will help guid readers/future-you on your through process!
Next time: comment on more of the output. Did you find anything interesting from the results (graph and tables)? Have the results prompted you to dig deeper in a certain direction? This will help guide future-you, or other readers.
Add a name to each code chunk. The name should reflect the function of the code chunk. To check what I mean, go to your hw01-vetlebh/hw01_swiss_files/figure-markdown_github/ folder and try to guess what chunk is what. This indexing/naming will help diagnose errors when knitting a file, organization of the repo, and overall ease of navigation.