@cbnicolau
First and foremost, I would like to commend you for such a great job on homework2 :smile: 👍. I have a few remarks regarding the following key areas:
1. Coding Style:
Your coding style was excellent 👍. I noticed that almost half of your work was inclined to base R. A line like: range(gapminder$gdpPercap) would have preferably been written as:
I noticed that you implemented this style in some areas of your file and not in others. So, I still say excellent because you exhibited knowledge of good coding styles but you could apply them across all your work.
2. Coding strategy:
I loved your coding strategy. Your long code is very neat, broken down into smaller chunks and is easy to read 👍 . You could still break down lines like this: nlevels(gapminder$continent) as shown above. I also like the few comments you placed in your code. You could work with more comments since your awesome repo will be accessed by various people trying to learn from you.
3. Presentation: graphs:
Your graphs were fine as well, I like the use of a variety of ggplot features. Exploration with more ggplot geoms would have been great to see. Please see this cheat sheet for more awesome geom utilities.
Also, some of your plots were not explained, so your readers may not know your deductions or what to conclude from your analysis.
4. Presentation: tables:
I haven't seen any tables in your work. Data from functions like gapminder %>% head would need to be nicely represented in a table using the knitr() function which can be loaded using library(knitr). You could implement this in your next assignment. An example I can give you of this library's application is:
gapminder %>% head %>% kable()
this will print nicely structured tables in your output files.
5. Achievement, creativity:
I noticed that there were some aspects of the assignment that were not approached in your work, like exploring the data using alternative functions. I noticed that you mostly used str(), you could also apply other functions to explore the dataset and its variables. I also only saw the use of one key dplyr function filter(), others like select() or summarise() were not exhibited. You could also check for typos in your work e.g How does the lifeExp changes with gdpPercap?
6. Ease of access:
Your work was very accessible. You provided links that took me straight to the files of interest 👍
Remarks:
@cbnicolau First and foremost, I would like to commend you for such a great job on homework2 :smile: 👍. I have a few remarks regarding the following key areas:
1. Coding Style: Your coding style was excellent 👍. I noticed that almost half of your work was inclined to base R. A line like:
range(gapminder$gdpPercap)
would have preferably been written as:gapminder %>% select(gdpPercap) %>% range
or
ggplot(gapminder, aes(x = gdpPercap, y = lifeExp)) +
asgapminder %>% ggplot(aes(gdpPercap, lifeExp)) +
I noticed that you implemented this style in some areas of your file and not in others. So, I still say excellent because you exhibited knowledge of good coding styles but you could apply them across all your work.
2. Coding strategy: I loved your coding strategy. Your long code is very neat, broken down into smaller chunks and is easy to read 👍 . You could still break down lines like this:
nlevels(gapminder$continent)
as shown above. I also like the few comments you placed in your code. You could work with more comments since your awesome repo will be accessed by various people trying to learn from you.3. Presentation: graphs: Your graphs were fine as well, I like the use of a variety of ggplot features. Exploration with more ggplot geoms would have been great to see. Please see this cheat sheet for more awesome geom utilities. Also, some of your plots were not explained, so your readers may not know your deductions or what to conclude from your analysis.
4. Presentation: tables:
I haven't seen any tables in your work. Data from functions like
gapminder %>% head
would need to be nicely represented in a table using theknitr() function
which can be loaded usinglibrary(knitr)
. You could implement this in your next assignment. An example I can give you of this library's application is:gapminder %>% head %>% kable()
this will print nicely structured tables in your output files.
5. Achievement, creativity: I noticed that there were some aspects of the assignment that were not approached in your work, like exploring the data using alternative functions. I noticed that you mostly used
str()
, you could also apply other functions to explore the dataset and its variables. I also only saw the use of one key dplyr functionfilter()
, others likeselect()
orsummarise()
were not exhibited. You could also check for typos in your work e.gHow does the lifeExp changes with gdpPercap?
6. Ease of access:
Your work was very accessible. You provided links that took me straight to the files of interest 👍
Great job! @cbnicolau