STAT545-UBC-hw-2018-19 / hw03-JasmineLib

hw03-JasmineLib created by GitHub Classroom
0 stars 0 forks source link

Peer review #1

Open ntjjmak opened 6 years ago

ntjjmak commented 6 years ago

Hi Jasmine,

Here is my review of your homework.

Topic Excellent Satisfactory Needs Work
Coding style 😄    
Coding strategy 😄    
Presentation: graphs 😄  
Presentation: tables 😄    
Achievement, creativity 😃    
Ease of access 😄 :    

Things I liked: 1) Code was pretty easy to read. Even if there were commands I had not seen before, I could see what you were trying to do. 2) I liked the format of the tables and graphs. Very easy to interpret. 3) I thought the use of colours/shapes/lines in your graphs was pretty creative. Suggestions: 1) The maximum and minimum graph was the only one that was not so straight forward to read. The vertical distance between the points was challenging to compare between continents. Perhaps you could have considered trying a different type of graph. What I learned: 1) I will try to incorporate more formatting to my graphs because I see the difference it really makes. I could not figure out how to do trim means, so I will probably refer to your assignment for that!

Nicole

JasmineLib commented 6 years ago

@ntjjmak - thank you for all the comments!