TA comments

[ChadFibke]

Coding Style

The good :thumbsup:

• Good amount of code chunk comments to explain more complex code!

• Code is readable, nicely spaced, and syntax looks good!

Needs work :thumbsdown:

• Not a con, just a suggestion:

# there are alternative if else statments in r
if_else(a_conditon, "Print A is True",
        if_else(b_conditon, "Print B is True",
               if_else(C_conditon,"Print C is True", "THE SKY IS FALLING")))
# But if you like you if and else if that is also fine!

• Some spaces in your code are effective while others are not. For example a lot of you assignment operators have no spaces between the object and the coordinating value. Please see here for more consistent spacing.

Coding Strategy

The good :thumbsup:

• Great use of conditional statements to control the flow of your code!

• Great use of a reactive variable inside of your server function :star:. This cleans up the code and makes this run more smoothly!

Needs work :thumbsdown:

• When making a widget, it is always best to make informative labels. The label provides the user with information on what the widget controls. Your widget labels are almost informative, but there is no documentation to let the user know how the app will react (except the bandwidth for histogram).

• Your dropdown list is long, and un ordered, which makes it harder to navigate. It is possible to group your list by continent, or by any other aspect using:

selectInput("Country_you_want", "Select Country", list(   "Europe" = c("Germany", "Spain"),   "North America" = c("Canada", "United States" = "USA") )) 

# This example was taken from https://github.com/daattali/advanced-shiny/tree/master/dropdown-groups

• You had a good start using tabsetPanel() to clean up your App, but I think having the widgets, tables, and histogram on one tab is a bit much! Consider putting the table on an additional tab to have a more organized look!

Graphs

The good :thumbsup:

• Graphs are reactive!

• Excellent use of a reactive ... text to explain what the graph is showing :star:. This is the first report to do so.

• Good use of aesthetics to compliment the amount of products selected.

• Went above and beyond with visualizing the network! Im sure if there was a Vancouver option it would only have craft beer.

Needs work :thumbsdown:

• Instead of adding a render text you could also add an official reactive title for your graph using something like:

ggtitle(sprintf("This graph shows %s, from %s between the prices %s and %s", input$typeInput,input$countryInput, input$priceInput[1],input$priceInput[2]))

# since this is already in a renerplot (reactive context) the title will change for you :)

• Consider using aesthetics to color your histogram to show the distribution of each product type (if multiple types are selected). This will give the user a more precise result. With one colour, we don't know if wine, beer, or another product type is the most expensive within a given range.

Tables

The good :thumbsup:

• Tables were reactive, and thanks for using renderDataTable() to clean the App up, and make the tables more interactive!

Needs work :thumbsdown:

• NA

Creativity & Ease of Access

The good :thumbsup:

• Easy navigation from canvas to your shiny app!

• Thanks for supplying a link to your sources, and explicitly saying what you had modified. Everything was well done!

Needs work :thumbsdown:

• Be sure to use appropriate directories (in you github repo) to store related objects. For example, to make things a bit cleaner you could have added a data folder to store your dependency data (bcl-data.csv). This isn't huge mistake, but as the repo grows unsorted files will make the repo very.. messy.

• The README should have an explanation of what the app is doing (Think of the 5 W's). Also, this README should have a sales pitch for your App! Marketing-101 – Why should people use your product?!

[ChadFibke]

Sorry

• I gave you do contradicting comments: "Good use of aesthetics to compliment the amount of products selected" AND "Consider using aesthetics to color your histogram to show the distribution of each product type (if multiple types are selected). This will give the user a more p...". Please ignore the first comment!! Looks like I need my second cup of coffee. Anyways, great job!