STAT547-UBC-2019-20 / group05

Repository for our team project (group 05)
0 stars 3 forks source link

Assignment 03 _Peer Review (Farnaz) #33

Closed Farnaz1234 closed 4 years ago

Farnaz1234 commented 4 years ago

Hi Group 5!

Overall, it seems all like a great report with good analysis, well done!

jacobgerlofs commented 4 years ago

Thanks @Farnaz1234 for the feedback! I've copied your comments below and addressed them line-by-line

Hi Group 5!

  • I ran your codes (scripts) on my computer using the commands you suggested and your final reports and plots were correctly generated except for scripts/load.r. Great job!

I'm not sure in which ways load.r was not generated correctly. However, it could be due to not capitalizing the ".R" correctly? In any case, we've now updated the usage section of the read me to have appropriately capitalized command line arguments. I hope this fixes the issue?

  • You loaded package readxl although not required, but okay to have it.

Yes, functions from this package were used in our load.R script :smiley:

  • I learned from your codes that I can use path = here instead of here::here. Thanks!

Glad you learned something yourself!

  • _I would recommend using read_csv and writecsv since you have loaded the tidyverse package instead of read.csv and write.csv in the base R package.

Good point, it was raised by another peer review that we used these two functions from both packages interchangeably. To be more consistent, we changed the all scripts to use only the tidyverse version of these functions.

  • You have your repository organized with all required folders ( data, docs, scripts, and images).
  • I see usage section in your README.
  • The analysis runs pretty quickly.
  • I liked your data set and your research question.
  • _I really liked the geompoint(position = "jitter") you used.

Thanks! :blush:

  • I believe it is more informative if you label your plots using labs(title= ).

Good point, we've added titles to our ggplots!