STAT547-UBC-2019-20 / group_01_dlin_njamshidi

MIT License
0 stars 3 forks source link

Milestone 04 #40

Closed dy-lin closed 4 years ago

dy-lin commented 4 years ago

Milestone 04

Task 1. Address peer feedback (40%)

Here is the priority suggested for addressing feedback:

  1. Fixing scripts that do not run on all systems/operating systems
  2. Fixing documentation to make sure its consistent with how to actually run scripts
  3. Cleaning up the repo directory
  4. Improving script analysis/processing time (think about vectorization or using purrr functions)
  5. Improving plots
  6. Clarifying research questions
  7. Improving analyses
  8. Adding analyses (not required)
  9. Other feedback

TA Feedback #9

TA Feedback #25

Peer Feedback #35

Peer Feedback #39

Task 2: Dashboard Proposal (50%)

Example Description

This app will have a landing page that shows the distribution (depending on data type, bar chart, density chart etc) of dataset factors (hypertension, physical disabilities etc.) colour coded according to whether or not patients showed up for an appointment. From a dropdown list, users will be able to filter out variables from the distribution display, by patient demographics (i.e. only show female patients), by appointment data (i.e. if SMS was sent), and finally by the date range of appointments. A different dropdown menu will allow users to re-order variables according to the probability of patients being a no-show or in alphabetical order to comorbidities. Users can compare the distribution of co-morbidities by scrolling down through the app interface.

Usage Scenario

Example Usage Scenario

Mary is a policy maker with the Canadian Ministry of Health and she wants to understand what factors lead to missed appointments in order to devise an intervention that improves attendance numbers. She wants to be able to [explore] a dataset in order to [compare] the effect of different variables on absenteeism and [identify] the most relevant variables around which to frame her intervention policy. When Mary logs on to the “Missed Appointments app”, she will see an overview of all the available variables in her dataset, according to the number of people that did or did not show up to their medical appointment. She can filter out variables for head-to-head comparisons, and/or rank order patients according to their predicted probability of missing an appointment. When she does so, Mary may notice that “physical disability” appears to be a strong predictor missing appointments, and in fact patients with a physical disability also have the largest number of missed appointments. She hypothesizes that patients with a physical disability could be having a hard time finding transportation to their appointments, and decides she needs to conduct a follow-on study since transportation information is not captured in her current dataset.

Note that in the above example, “physical disability” being an important variable is fictional - you don’t need to conduct an analysis of your data to figure out what is important or not, you just need to imagine what someone could find, and how they may use this information.

Example Sketch

A further note on the app sketches:

This sketch is drawn up Powerpoint and using icons from the noun project. You can use others graphics tools (i.e. Photoshop, Illustrator, GIMP, or Inkscape, etc.) or you can even draw you app by hand and upload the scanned version of your drawing. Whatever you choose to do, make sure that the final image in your report is legible. Please note, this is a very basic illustrative guide to help you in this milestone, it is by no means the limit of what you should submit.

Task 3. Start your dashboard (10%)

dy-lin commented 4 years ago

@Nima-Jamshidi I have finished addressing the feedback, the only one that I left to Future work is #41, about reorganizing the repository. I personally feel like this piece of advice is unnecessary, so I left it to future work.

In the meantime, I am working on a hand-drawing a sketch of our dashboard-- I suggest you do the same and upload it to this issue, and we can compare our ideas and finalize a mockup and do the writeup.

dy-lin commented 4 years ago

Hi @Nima-Jamshidi, I did the first page of the dashboard sketch-- if you follow my lead, you can do the second page for your linear regression plots.

I used diagrams.net (aka draw.io) to make the diagram.

You can work off my template here, or hand-draw, etc: https://drive.google.com/file/d/1hF9JSO34CR07xqUNOLFzDIUJbDcWplHz/view?usp=sharing

Basically, just keep the title and the exploration vs linear regression radio buttons consistent with mine.

You will need to sign into your google account, and 'open with... diagrams.net' when you click on the link. You'll need to authorize diagram.net if you have never used it before.

I've attached my image here too, and I will upload it to the repository and update the README. STAT547

dy-lin commented 4 years ago

As for the write-ups for description and usage scenarios, since we're not supposed to use our forks, we can just edit the README.md file using the GitHub web browser interface.

Nima-Jamshidi commented 4 years ago

Hi Diana,

Thank you for writing the replies to feedbacks. I have made the second page in draw.io . However, strangely it doesn't export the cursor shape and prints cross box instead. Could you try the link below to export a png file? Second page on draw.io This is the result I get: STAT547- page 2

dy-lin commented 4 years ago

Hi @Nima-Jamshidi, I had the same issue as you. I ended up exporting as a PDF and then saving as a PNG. I will upload it to our repository and add it to our README.

page2

dy-lin commented 4 years ago

@Nima-Jamshidi We still need to do the description and usage scenario. Which one do you want to do? We will have to each write about ~150 words for each sections.

Nima-Jamshidi commented 4 years ago

@dy-lin Oh cool! Thanks! I should change part of it; will upload the modified one. Since you did the feedback task, I can do these two sections, if you are okay with that.

dy-lin commented 4 years ago

Sure, sounds good to me (you can do both)! I added the image already to the README.md, so when you upload your new PNG, just make sure it's in the images directory, named sketch_page2.png (images/sketch_page2.png)

Very weird that the cursor doesn't show! I didn't have issue when I did mine, but I also couldn't make the icon show when using your file on my computer.

dy-lin commented 4 years ago

Hi @Nima-Jamshidi, any progress on the Description/Usage? I see both those parts on the README still have their 'placeholders'. Do you need any help? The milestone is due tonight at 6pm.

Nima-Jamshidi commented 4 years ago

It's done @dy-lin . Please check them and modify them if you wish. Afterwards, we can submit the milestone.

dy-lin commented 4 years ago

Thanks @Nima-Jamshidi! Can you tag the release and submit to Canvas? I will do it by 5:30 if it's not done by then.

Nima-Jamshidi commented 4 years ago

I submitted it with the notion of equal distribution. Cheers!