search

STELLA-LYE / pe

0 stars 0 forks source link

Help Command still proceeds on with invalid format #1

Open STELLA-LYE opened 7 months ago

STELLA-LYE commented 7 months ago

Screenshot 2024-04-19 at 4.54.57 PM.png

When an invalid command format for help command such as help 444 is entered, the help window is still displayed.

Screenshot 2024-04-19 at 4.55.55 PM.png

Perhaps it will be more clear and useful for the application to stick strictly with just help input as specified in the User Guide :)

Screenshot 2024-04-19 at 4.57.35 PM.png

nus-pe-bot commented 7 months ago

Team's Response

This is a duplicate, as both involve extraneous parameters not being acknowledged and not having an error raised for commands without parameters like exit and clear.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Clear Command still proceeds on with invalid format

Similarly, the Clear command also proceeds with invalid input following after clear. For instance, when clear 444 is entered, the data will still be cleared.

Perhaps the team can also consider modifying the application such that clear command proceeds only when clear is entered and else an error message or warning would be provided.

Screenshot 2024-04-19 at 4.59.04 PM.png

[original: nus-cs2103-AY2324S2/pe-interim#4291] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Works as intended, because some features like help, exit, clear are intended to ignore extraneous parameters. This is a strictly documentation bug as we failed to note it down in the UG.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The 'Original issue' is different from this current issue. The original one addresses the 'clear' feature whereas this issue addresses the 'help' features.

Fixing the above original documentation bug does not automatically fixes the documentation bug for 'help' command. These two issues still has to be fixed independently and are two different areas of documentation bugs. Furthermore, according to CS2103 website, the above does not qualify for duplicate bugs as it does not appear in more than five distinct places. Hence, I believe that they do not qualify as duplicates.

Screenshot 2024-04-23 at 3.50.32 PM.png

Screenshot 2024-04-23 at 3.53.07 PM.png

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]