STELLA-LYE / pe

0 stars 0 forks source link

Does not detect the use of invalid flags or prefixes #4

Open STELLA-LYE opened 7 months ago

STELLA-LYE commented 7 months ago

Screenshot 2024-04-19 at 5.06.24 PM.png

Screenshot 2024-04-19 at 5.07.30 PM.png

When invalid flags such as /remark jjjj is entered as shown above, the application still proceeds to add the internship. A warning or error message could be helpful to detect this use of invalid flag.

soc-se-bot commented 7 months ago

Team's Response

We consider this as a duplicate of #2518, since both problems arise from the inability to detect invalid prefixes, and instead considering them as a part of string arguments for the previous prefix and allowing the command to go through. In addition, both problems can be fixed by adding functionality for the app to detect invalid prefixes.

image.png

We consider this as case b, as both bugs require the added functionality for the app to detect invalid prefixes, without which neither bug can be resolved.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Feature flaw due to not detecting easy-to-correct command flags (e.g., /des vs /desc)

image.png

The system fails to suggest the correct command flag when users mistakenly enter /des instead of /desc, leading to potential confusion and inefficient user interaction with the application.

Rationale: severity.Low This flaw impacts the user experience by not assisting in correcting common input errors, which could be easily rectified by the system. From CS2103 Website https://nus-cs2103-ay2324s2.github.io/website/admin/tp-pe.html#tp-practical-exam:

image.png


[original: nus-cs2103-AY2324S2/pe-interim#2092] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** The team has made an attempt to justify their decision to downgrade the aforementioned issue to a low priority. However, the provided explanation lacks depth and fails to persuade me why it warrants a low priority status. This flaw intermittently inconveniences users, as prefixes/flags are commonly utilized and form a vital part of the commands. Moreover, many commands employ multiple prefixes/flags and the commands are often very lengthy and cumbersome to key in. Therefore, it can be common and frequent that users make mistakes when entering the commands but the application is unable to detect this. Although the product still functions as normal, this feature flaw can still bring great inconvenient for users. ![Screenshot 2024-04-23 at 4.08.14 PM.png](https://raw.githubusercontent.com/STELLA-LYE/pe/main/files/fa54e7dc-43ae-4dbb-9738-825ba58987b7.png)