STEP-Pod-Capstone-Project / Capstone-Project

https://book-book-app.appspot.com

Apache License 2.0

4 stars 0 forks source link

Members Functionality for SearchUserModal #121

Closed MauroGuerrero20 closed 4 years ago

MauroGuerrero20 commented 4 years ago

Features

Adds Members functionality to the SearchUserModal
- Users can now add members to your club using this modal in the ClubPage
Removes Friends Functionality from the Modal.

Demo

SearchUserModal Club Member Demo

Depends on https://github.com/STEP-Pod-Capstone-Project/Capstone-Project/pull/117

MauroGuerrero20 commented 4 years ago

Looks good to me! This was one of our last core features for the club page and it makes it really clean it use!

I agree with Steven, it doesn't seem to make sense that they get added to the bottom of the modal if they are just added as a friend.

Friends and club members will appear at the bottom. This design choice was done because I thought people would like to invite their friends to a club. We should discuss more on a GVC.

steven-solar commented 4 years ago

@MauroGuerrero20 I agree friends appearing in the modal would be helpful, but as of now when you add Vivek as a friend he appears under the "Club Members" header which is misleading as he is not a club member. Not sure the best way to display friends in the modal, but maybe another header with your friends beneath it?