search

STEPBible / BibleEngine

General purpose library for powering JavaScript Bible projects
44 stars 9 forks source link

WIP: Add infinite scrolling and scroll-to-verse #161

Closed danbenn closed 4 years ago

danbenn commented 4 years ago

Summary

This PR:

  1. Speeds up render performance by only rendering one text string, instead of hundreds of individual word elements
  2. Adds infinite scrolling
  3. Adds scroll-to-verse from clicking search result

Test Plan

Manual QA seems like most valuable option at this point

DavidIB commented 4 years ago

Sounds great! Should I be seeing this without updating? (I don’t think I do). The Android Play store isn’t offering any update.

DavidIB commented 4 years ago

Ah - I see - it isn't merged yet

danbenn commented 4 years ago

Closing because I'm going to do a total re-write of the app using Capacitor and Vue (web technologies)

I was running into some big limitations of React Native