STEPBible / BibleEngine

General purpose library for powering JavaScript Bible projects
44 stars 9 forks source link

Fix incorrect strongs tag parsing #176

Closed danbenn closed 3 years ago

danbenn commented 4 years ago

Examples

https://photos.google.com/share/AF1QipNxu2wSqTGh5FqE1HkcrjhOdbNwt2ORK97H3Irzp_9s6Ejd9AVl_hCNayKwmAJQ_A?key=a0VuSGdGcmxLLUZKc3dFaklNbHJpN1AwVWlRcWNn

Digging Deeper

eg Lev.23.38 "all your freewill offerings" is linked in ESV tagging with H5071 ('voluntariness') The Hebrew tagging is: H3605#4=כֹּל=all/ H5071#4=נְדָבָה=voluntariness}/ H9026#6=Pp2m=your In the App this is H5071 ('voluntariness) + H0026 ('Abigail') + H0002 ('father') + H0006 ('to perish) + H0005 ('Abagtha') + H0905 ('alone') + H3606 ('all') What it should be is H5071 + H9026 + H3606 (not necessarily all of them or in that order)

eg Lev.23.4 "which...the time appointed for them" is linked in ESV tagging with H4150 The Hebrew tagging is : H9003#1=ב=in/ H4150#4=מוֹעֵד=meeting_§1_time_appointed/ H9028#6=Pp3m=their/ H0853#4=אֵת=obj./ H9038#6=Op3m=them In the App this is H4150 ('meeting') + H0853 ('[Obj.]') + H0038 ('Abijam') + H9003 ('in|on|with') What it should be is H4150 + H9028 + H0853 + H9038 + H9003 (not necessarily all of them or in that order)

The only pattern I can see is that the App possibly has H0006 for H9006, H0026 for H9026 and H0038 for H9038.

danbenn commented 3 years ago

Closing in favor of adapting @chriswep 's OSIS parser to work with Sword.

That parser fixes all these bugs, and more: Psalm headings, correct indentation blocks, etc