search

STEPBible / BibleEngine

General purpose library for powering JavaScript Bible projects
44 stars 9 forks source link

Dark mode feature for StepBible App #199

Closed patrickxchong closed 2 years ago

patrickxchong commented 2 years ago

Addresses dark mode issue at #107

danbenn commented 2 years ago

Can you verify that this complies with the guidelines here?

https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/dark-mode

patrickxchong commented 2 years ago

Check system dark theme to initialise value

patrickxchong commented 2 years ago

Try Object.assign instead of deepmerge Edit: done

danbenn commented 2 years ago

Consider using underline like the Literal Word app does, great UX feature - but not essential, can use existing color highlighting if Text component isn't cooperative

patrickxchong commented 2 years ago

Popover border in dark mode Edit: replaced with changing popover background color in dark mode

patrickxchong commented 2 years ago

Consider using underline like the Literal Word app does, great UX feature - but not essential, can use existing color highlighting if Text component isn't cooperative

Done with 

borderBottomWidth: 1,
borderBottomColor: "gray",

in StrongsWord.tsx