search

STEPBible / step

STEP :: Scripture Tools for Every Person
BSD 3-Clause "New" or "Revised" License
49 stars 38 forks source link

Internal refs should go to the current Bible but currently go to the default Bible (ESV) #106

Open DavidIB opened 2 years ago

DavidIB commented 2 years ago

EG at https://www.stepbible.org/?q=version=SpaNVI|reference=1Kgs.2&options=VUGVNH&display=INTERLEAVED there are links to parallel passages. image Currently, if you click on them, they open in ESV. THe link is < a xref="1Ch 29:26-28" class="linkRef" title="1Ch 29:26-28" href="?q=version=ESV|reference=1Chr.29.26-1Chr.29.28">1Cr 29:26-28 but should be: < a xref="1Ch 29:26-28" class="linkRef" title="1Ch 29:26-28" href="?q=version=SpaNVI....

The version isn't set by the OSIS module which has: 

<hi type='italic'>
<reference osisRef='1Kgs.2.10-1Kgs.2.12'>2:10-12</reference> – 
<reference osisRef='1Chr.29.26-1Chr.29.28'>1Cr 29:26-28</reference>
 </hi>

So the version must be added within the STEPBible coding. It is probably set to the 'default' Bible, or perhaps specifically to ESV. It should be set to the same Bible that the reference is found in.