search

STEllAR-GROUP / hpx-kokkos

HPX/Kokkos interoperability library
Boost Software License 1.0
6 stars 3 forks source link

Add get_future member method for convenience #9

Closed G-071 closed 2 years ago

G-071 commented 2 years ago

This PR simply adds a get_future member method to the executors to make them more compatible with the hpx::cuda::experimental::cuda_executor.

As for my use-case: I have some templated functions that call executor.get_future(). Originally, this was developed to be used with the HPX CUDA/HIP executors (which already have the get_future member method), but I would like that method to simply work both with the Kokkos- and with the CUDA/HIP HPX executors without changing too much! Hence this small addition to hpx-kokkos!

msimberg commented 2 years ago

Seems harmless enough, thanks @G-071! ~I realize now I haven't merged the release-0.3.X branch into master. I'll do that first before merging this, and I think (hope!) that there won't be any conflicts. That part of the code didn't really change between the releases.~ That was a lie.