The newer hydro flux kernels (all of them, VC, CUDA, Kokkos) were not doing this, causing swapped ur/ul and vr/vl columns in the time step output on the console!
@dmarce1 @shibersag I assume the UL/UR swap in the legacy mentioned above is intentional? In case it is: This PR adds the swap when storing UL and UR in the time step variable for all kernels.
The legacy flux kernel swaps UL and UR when storing the respective values for the time step: https://github.com/STEllAR-GROUP/octotiger/blob/f2a9c5d50d05d6050ffb5980601b68501de1ee6c/octotiger/unitiger/hydro_impl/flux.hpp#L111 https://github.com/STEllAR-GROUP/octotiger/blob/f2a9c5d50d05d6050ffb5980601b68501de1ee6c/octotiger/unitiger/hydro_impl/flux.hpp#L112
The newer hydro flux kernels (all of them, VC, CUDA, Kokkos) were not doing this, causing swapped ur/ul and vr/vl columns in the time step output on the console!
@dmarce1 @shibersag I assume the UL/UR swap in the legacy mentioned above is intentional? In case it is: This PR adds the swap when storing UL and UR in the time step variable for all kernels.