Add eos ipr tests - Githubissues

STEllAR-GROUP / octotiger

Astrophysics program simulating the evolution of star systems based on the fast multipole method on adaptive Octrees

http://octotiger.stellar-group.org/

Boost Software License 1.0

48 stars 18 forks source link

Add eos ipr tests #414

Closed G-071 closed 2 years ago

G-071 commented 2 years ago

This PR is aiming to add tests for the new equation of state in added in PR #410

So far it is adding one test using the star scenario!

G-071 commented 2 years ago

Changes:

Added silodiff test for the new EOS option (only tests it for with LEGACY kernels for now - can be extended as we move along with the other kernels) using the STAR scenario with the parameters @shibersag provided. Silodiff tests all fields except lx, ly, lz (see below).
Added terminal output test, comparing the time step output for the new EOS option (same scenario) to have a second basic test that does not depend on silo (or our IO methods).

Issues:

The output for the lx ly lz fields does not match for runs between different machines (or different gravity kernels for that matter). This does not seem to be related to this PR (or the new EOS option) but to the STAR scenario (or some of the utilized parameters) itself - hence I think we can move forward with this PR. I will open a separate issue to track this.

I ran the tests on all machines a couple of times now! Except for the above-mentioned issue, everything seems to be running fine! I think this is good to go: @shibersag can you have a look at it?