STEllAR-GROUP / octotiger

Astrophysics program simulating the evolution of star systems based on the fast multipole method on adaptive Octrees
http://octotiger.stellar-group.org/
Boost Software License 1.0
48 stars 18 forks source link

Fix local communication #427

Closed G-071 closed 1 year ago

G-071 commented 2 years ago

This PR removes the pointer exchange between neighboring sub-grids for the hydro solver! Originally, these were added in #426 to optimize the communication when sub-grids were located on the same locality.

Instead of the raw pointer, hpx::get_ptr is now used to access this data!

The PR also contains two fixes for this optimization when running the DWD scenario: Here we allocated one promise too little (resulting in trying to set the same promise twice). Further, it could happen that the AMR communication went awry due to a missing check whether the parent is on the same locality. This PR resolves both issues!