STEllAR-GROUP / octotiger

Astrophysics program simulating the evolution of star systems based on the fast multipole method on adaptive Octrees
http://octotiger.stellar-group.org/
Boost Software License 1.0
48 stars 18 forks source link

Fix cross compilation when OCTOTIGER_WITH_CUDA=OFF. #441

Closed JiakunYan closed 1 year ago

JiakunYan commented 1 year ago

If OCTOTIGER_WITH_CUDA is set to OFF, cmake will append -march=native to the compilation flag. It doesn't look right and conflict with -mcpu=a64fx when doing cross compiliation on Ookami.

I think #428 should also apply this change. At least I cannot compile #428 on Ookami correctly without this change.

G-071 commented 1 year ago

LGTM. I think we can ignore the one failing test as it appears to be due to module problem on the AMD node and is not Octotiger-related.