Fix function template duplicated explicit instantiation

STEllAR-GROUP / octotiger

Astrophysics program simulating the evolution of star systems based on the fast multipole method on adaptive Octrees

http://octotiger.stellar-group.org/

Boost Software License 1.0

48 stars 18 forks source link

Fix function template duplicated explicit instantiation #442

Closed JiakunYan closed 6 months ago

JiakunYan commented 1 year ago

Previously, certain combinations of OCTOTIGER_WITH_GRIDDIM and OCTOTIGER_THETA_MINIMUM, INX == STENCIL_MAX will happen and compiling octotiger will fail with the error of function template duplicated explicit instantiation. This PR fixes this error.

diehlpk commented 1 year ago

@G-071 and @JiakunYan can this ticket be closed or will it be merged?

JiakunYan commented 1 year ago

@diehlpk It would be great if it could be merged. I don't see any reason against it.

diehlpk commented 1 year ago

@G-071 can you pleas have a look?

JiakunYan commented 6 months ago

@G-071 @diehlpk Any chance we could merge this PR recently?