search

STEllAR-GROUP / octotiger

Astrophysics program simulating the evolution of star systems based on the fast multipole method on adaptive Octrees
http://octotiger.stellar-group.org/
Boost Software License 1.0
48 stars 17 forks source link

Move run_as_os_thread from hpx::threads to hpx:: #476

Open G-071 opened 6 months ago

G-071 commented 6 months ago

run_as_os_thread was moved to a different namespace within HPX. This caused some deprecation warnings (and in the case of hipcc actually some compilation errors). This PR should fix that by using the updated namespace.

G-071 commented 6 months ago

Unfortunately, changing the namespace make Octo-Tiger incompatible with HPX 1.9.1 as it is still using the old one (hence the failing tests). I think we should postpone this PR at least until the next stable HPX release!

I will attempt to fix the issue with the hipcc compilation on the HPX side though so that we can still use HPX master on AMD devices if required!

diehlpk commented 2 weeks ago

@G-071 Since HPX 1.10 is releases could we switch to this version and merge the pull request?