STEllAR-GROUP / octotiger

Astrophysics program simulating the evolution of star systems based on the fast multipole method on adaptive Octrees
http://octotiger.stellar-group.org/
Boost Software License 1.0
48 stars 17 forks source link

Fix Octo-Tiger segfaults when using HPX master - V2 #479

Closed G-071 closed 6 months ago

G-071 commented 6 months ago

Using HPX master uncovered an issue within Octo-Tiger causing segfaults during the initialization (as outlined in the original HPX issue https://github.com/STEllAR-GROUP/hpx/issues/6414 and the PR https://github.com/STEllAR-GROUP/hpx/pull/6415).

This PR fixes this issue!

The original hotfix #477 would have already fixed this issue as well, however, a proper fix (like this PR) using hpx::get_ptr and shared_ptrs was easier to add than I initially thought. Hence I closed #477 in favor of this one!