I noticed some differences in the UR, UL values between the Kokkos and Legacy runs in the Octo-Tiger TS output (the timestep information) that gets printed every few time-steps.
I tracked these differences down to the maximum search for a in the flux kernel. While both the Kokkos and Legacy kernel variants actually always found the same maximum, the U values stored in ts (for subsequent printing to CLI) actually depended on the direction in the Kokkos kernel but not in the Legacy kernel.
This PR fixes this small oversight. Now the same values are getting printed.
While I was at it, I removed some of the unused code in reconstruct/flux.hpp (leftovers from the initial GPU port) and added some more assertions.
I noticed some differences in the UR, UL values between the Kokkos and Legacy runs in the Octo-Tiger TS output (the timestep information) that gets printed every few time-steps.
I tracked these differences down to the maximum search for a in the flux kernel. While both the Kokkos and Legacy kernel variants actually always found the same maximum, the U values stored in ts (for subsequent printing to CLI) actually depended on the direction in the Kokkos kernel but not in the Legacy kernel.
This PR fixes this small oversight. Now the same values are getting printed. While I was at it, I removed some of the unused code in reconstruct/flux.hpp (leftovers from the initial GPU port) and added some more assertions.