search

STEllAR-GROUP / phylanx

An Asynchronous Distributed C++ Array Processing Toolkit
Boost Software License 1.0
75 stars 76 forks source link

Make distributed span indices compatible with phylanx conventions #1133

Closed taless474 closed 4 years ago

taless474 commented 4 years ago

This PR changes the starting dimension of tiling spans in a way that they are compatible with node data conventions. For example, in a 3d array, the first dimension is the page dimension, the second one is the row dimension and then we have the column dimension (pages x rows x columns). The distributed version of dot and cannon_product uses get_span directly, so these primitives are modified. Also, tiling_information dimensions are adapted for the PHYLANX_MAX_DIMENSIONS, 4. To comply with node_data, the name of dimension() member function of the localities_information is changed to num_dimensions() (It returns a size_t that is the number of dimensions).

taless474 commented 4 years ago

Please let me fix #1137 problem here. I have not changed anything in constant and random since the tests were passed.

hkaiser commented 4 years ago

Please let me fix #1137 problem here. I have not changed anything in constant and random since the tests were passed.

Please let me know once this is ready to go.

taless474 commented 4 years ago

This PR would fix #1129 and #1137. It assumes that for a column vector spans size is 1 (e.g. spans =[[start, stop]]). For a row vector spans has a unit number of dimensions, but it is represented as spans = [[0,0],[start,stop]].