search

STEllAR-GROUP / phylanx

An Asynchronous Distributed C++ Array Processing Toolkit
Boost Software License 1.0
75 stars 76 forks source link

Should update XtX after the user loops in ALS #1220

Closed NanmiaoWu closed 4 years ago

NanmiaoWu commented 4 years ago

In ALS, XtX should be updated after the user loops. So, instead of in line 72 in https://github.com/STEllAR-GROUP/phylanx/blob/master/examples/algorithms/als/als_csv.cpp#L72, XtX should be moved to line 86, which is just above the item loops.

hkaiser commented 4 years ago

@NanmiaoWu would you be able to create a PR for this?