STFC-ICD-Research-and-Design / supermusr-data-pipeline

Prototype data acquisition pipeline for Super-MuSR
GNU General Public License v3.0
0 stars 3 forks source link

Add testing utility crate #254

Open DanNixon opened 1 week ago

DanNixon commented 1 week ago

Summary of changes

Adds a barebones testing utility crate (mostly stolen from Satori).

Resolves #253

Instruction for review/testing

Modularius commented 1 week ago

Did some minor error handling improvements.

Is this intended to be called from a yet to be made binary? Or will this crate eventually be converted into one? In the former case the functions should return Results rather than panic before I approve, but in the latter case, I can approve as I imagine error handling would be done later.

DanNixon commented 17 hours ago

Did some minor error handling improvements.

Since this code will only ever be used within tests it is technically exempt from the error handling style rules, although the changes are still for the better.

Is this intended to be called from a yet to be made binary?

It will be used by a suite of integration tests. It does not necessarily need to be it's own crate, that is just the route I went with in Satori. On second consideration it is probably a better idea to just have this code inside the crate that will contain the tests.

DanNixon commented 16 hours ago

Note that this is still work in progress (indicated by being a draft PR) please avoid modifying it for the time being.