search

STFCcommunity / botfeedback

Feedback for bot features
1 stars 0 forks source link

.bp sal.... doesn't work but .bp ent does. #18

Closed hamilton1977 closed 3 years ago

hamilton1977 commented 3 years ago

[34-DRED] MrHamster — Today at 7:50 PM .bp sal KMA Beta BOT — Today at 7:50 PM Sorry Commander, I haven't found a ship with this name or alias.

Not sure what other ship has "sal" but if there is to maybe list both. but, this says sal isn't there.

hamilton1977 commented 3 years ago

Can we just make all ships work with the 1st 3 letters even if it returns a few. Or, it asks which one.

WebSpider commented 3 years ago

Well, you are assuming here that the ship is the first argument, which it doesnt have to be. After all, .ship bp sally also works.

We could, before reporting the failure, attempt to see if we can do a partial match of any remaining argument longer than 2 chars we don't understand (such as sal, because that's not mapped to USS Saladin) to see if we find ships. If we find multiple (such as when searching for uss), we would present a dialog for the user to choose. Is this what you mean ?

Also, next time please report issues in the https://github.com/STFCcommunity/botfeedback/ repository, this one is used for the data that is used by the bot and other projects (currently just the wiki, but who knows what we come up with)

hamilton1977 commented 3 years ago

yeap. most ppl call it a sal or sally. so, if given 3 letters then see if it matches anything related to the command given. if it returns more then just one item give options that are related to the command given.

I didn't go down the full list of ships to see if any others returned something.

😇 but i will soon 😍