search

STFinancial / Minecraft

0 stars 0 forks source link

Banned Items #7

Closed Boxxy closed 10 years ago

Boxxy commented 10 years ago

Check players inventory, remove any of the follow items (no exhaustive list) Ender Pearls, Flint and Tinder, Fire Charge, God Apples, Golden Apples, any Potion exceeding the first 3 potions (splash or regular)

Boxxy commented 10 years ago

Almost completed

Boxxy commented 10 years ago

One bug in over 3 potions needs to be investigated in an attempt to recreate, taking in 4 potions could leave the user with more than one potion deleted

STFinancial commented 10 years ago

From what I can see, the problem seems to be if you have multiple of the same time of potion. Basically you're removing that entire stack of potions, regardless of how many need to be removed to prevent the person from exceeding the limit. So for example, I bring:

1 potion X 1 potion Y 2 potion Z

From what I can tell, the current function will remove all instances of potion Z, even though only 1 needs to be removed, resulting in more than one potion deleted.

On Thu, Jul 31, 2014 at 10:05 AM, Clayton Hawken notifications@github.com wrote:

One bug in over 3 potions needs to be investigated in an attempt to recreate, taking in 4 potions could leave the user with more than one potion deleted

— Reply to this email directly or view it on GitHub https://github.com/STFinancial/Minecraft/issues/7#issuecomment-50771513.

Timothy Pallarino University of Minnesota '15 Undergraduate of Chemical Engineering

qsik commented 10 years ago

Done. Testing needed

Boxxy commented 10 years ago

Last test was good, stress test it once more (taking in tons of banned items) to finish