Open blazgocompany opened 1 week ago
Could you provide a picture...?
I cannot test what it looks like but maybe you can. I know it looks good...
Could you provide a picture...?
The hover effect is nice, but the colors could be improved...
How did you make it if you didnt test it? And no i cannot provide one since i dont have access to a pc rn
Could you provide a picture...?
The hover effect is nice, but the colors could be improved...
Ok yea this should be improved before possible merge
Wait somethings wrong..
Could you provide a picture...?
The hover effect is nice, but the colors could be improved...
Ok yea this should be improved before possible merge
For sure, yeah. I assume this isn't the finished result. I also added the white text color to the css before injecting it because before the contrast wasn't the best.
Possible ideas
blacks more readable on orange
add a bigger contrast between the "view all" button and background add "!important" on line 19. The View all should be black
Black on orange White on orange
Black on orange
White on orange
It isnt white tho, its a dark blue which id even more unreadable
The view all button and the box header should both be black. My original code was contrast tested
The view all button and the box header should both be black. My original code was contrast tested
Fair enough but the only reason I changed it then and there was because when I saw it it was:
Thats weird
Thats weird
No, you're right. I was just showcasing that the color it currently is should be darker (black) which you already noted as it's currently a shade of gray which looks off. So, just change the color to black and from a color standpoint it should be good 👍
ok I see its gray.
I had put color:black i dont see it anymore..
Done! See line 19 & 16
Yep, it's better now
Is that done?
I think this could work as an experimentational feature for now.
Would need others opinions
Like I said, it needs work! But it's definitely a start...
I'm back.
Like I said, it needs work! But it's definitely a start...
What work does it need? If you are talking about other Scratch pages, can't I just add them in future PR's?
I'm back.
Like I said, it needs work! But it's definitely a start...
What work does it need? If you are talking about other Scratch pages, can't I just add them in future PR's?
I'm not sure about their exact thoughts for what it needs, but if there's further intended usage, then we don't want to ship any unfinished features.
Ok I'll finish the home page styles by Monday.
Ok. I finished the home page. Let me know if you have any suggestions. Also I can't test the whole thing at once. I test it commit by commit so if you can send me a screenshot of what it looks like that would be great 👍🏼
Also, I was wondering how to use JavaScript in browser extensions. Is there anything different in browser extensions (especially for DOM manipulation)
Ok. I finished the home page. Let me know if you have any suggestions. Also I can't test the whole thing at once. I test it commit by commit so if you can send me a screenshot of what it looks like that would be great 👍🏼
The Scratch News white on light blue doesn't have a whole lot of contrast.
Uh Oh.. That screenshot scared me. Fixed. Also couple questions:
box-content
's look too dark?@callumjt's commit new desc
is not exectly what I wanted. This is for the entire Scratch site. It is just not implemented yet. It is coming soon
Uh Oh.. That screenshot scared me. Fixed.
Also couple questions:
- How do I use JavaScript in browser extensions? Is there anything different in browser extensions (especially for DOM manipulation)?
Check the docs :), and i dont think there are any differences in dom manipulation, at least afaik
@callumjt's commit
new desc
is not exectly what I wanted. This is for the entire Scratch site. It is just not implemented yet. It is coming soon
Ill change it later then
From skimming through the editor file it seems like its a dark theme although doesnt this just contradict the home page? Im sure others would agree, but it should be consistent
Yep. You're right. Ill think about it and get back.
What do you think? Should we have the Light background for everything or have Dark or what? It kind of makes sense to have just the editor dark but its your choice. My suggestion is have everything Dark and Ill work to add a light mode.
What do you think? Should we have the Light background for everything or have Dark or what? It kind of makes sense to have just the editor dark but its your choice.
If this only affects the homepage, then we should count on it being light.
No this is for the editor. My suggestion is have everything Dark and Ill work to add a light mode.
@blazgocompany Do you happen to have Discord?
No
No
I've seen your codepen work- would you be interested in joining the developer team on @STForScratch/website-developers
Sure
Any updates here?
@rgantzos @MaterArc @callumjt ?????
Ok there u are. I'm like its been 3 days and nothings happend
So here's what I need to know:
Are we doing dark/light theme
I would suggest any/all of these
@MaterArc what did you add at line 91?
So here's what I need to know:
- Do you have any other suggestions for the homepage?
- Does the background color of the orange box-content's look too dark?
- Are we doing dark/light theme
I would suggest any/all of these
- Dark editor, Light everything else
- Dark Everything
- Light Everything
- NOT the opposite of 1
So here's what I need to know:
- Do you have any other suggestions for the homepage?
- Does the background color of the orange box-content's look too dark?
- Are we doing dark/light theme
I would suggest any/all of these
- Dark editor, Light everything else
- Dark Everything
- Light Everything
- NOT the opposite of 1
I can answer bullets two and three right off the bat. The orange color looks fine to me, dark and light themes could be nice for customizability.
@MaterArc Thank you.
I will make more styles soon but for now its just a nicer home page.