STForScratch / ScratchTools

The perfect extension for Scratch.
https://scratchtools.app
GNU General Public License v3.0
73 stars 68 forks source link

New Home Page #842

Open blazgocompany opened 1 week ago

blazgocompany commented 1 week ago

I will make more styles soon but for now its just a nicer home page.

callumjt commented 1 week ago

Could you provide a picture...?

blazgocompany commented 1 week ago

I cannot test what it looks like but maybe you can. I know it looks good...

MaterArc commented 1 week ago
Screenshot 2024-06-21 at 5 15 42 PM

Could you provide a picture...?

The hover effect is nice, but the colors could be improved...

callumjt commented 1 week ago

How did you make it if you didnt test it? And no i cannot provide one since i dont have access to a pc rn

callumjt commented 1 week ago
Screenshot 2024-06-21 at 5 15 42 PM

Could you provide a picture...?

The hover effect is nice, but the colors could be improved...

Ok yea this should be improved before possible merge

blazgocompany commented 1 week ago

Wait somethings wrong..

MaterArc commented 1 week ago
Screenshot 2024-06-21 at 5 15 42 PM

Could you provide a picture...?

The hover effect is nice, but the colors could be improved...

Ok yea this should be improved before possible merge

For sure, yeah. I assume this isn't the finished result. I also added the white text color to the css before injecting it because before the contrast wasn't the best.

callumjt commented 1 week ago

Possible ideas

blazgocompany commented 1 week ago

blacks more readable on orange

blazgocompany commented 1 week ago

add a bigger contrast between the "view all" button and background add "!important" on line 19. The View all should be black

blazgocompany commented 1 week ago

image Black on orange image White on orange

callumjt commented 1 week ago

image

Black on orange

image

White on orange

It isnt white tho, its a dark blue which id even more unreadable

blazgocompany commented 1 week ago

The view all button and the box header should both be black. My original code was contrast tested

MaterArc commented 1 week ago

The view all button and the box header should both be black. My original code was contrast tested

Fair enough but the only reason I changed it then and there was because when I saw it it was:

Screenshot 2024-06-21 at 5 25 59 PM
blazgocompany commented 1 week ago

Thats weird

MaterArc commented 1 week ago

Thats weird

No, you're right. I was just showcasing that the color it currently is should be darker (black) which you already noted as it's currently a shade of gray which looks off. So, just change the color to black and from a color standpoint it should be good 👍

blazgocompany commented 1 week ago

ok I see its gray.

blazgocompany commented 1 week ago

I had put color:black i dont see it anymore..

blazgocompany commented 1 week ago

Done! See line 19 & 16

MaterArc commented 1 week ago
Screenshot 2024-06-21 at 5 32 27 PM

Yep, it's better now

blazgocompany commented 1 week ago

Is that done?

callumjt commented 1 week ago

I think this could work as an experimentational feature for now.

Would need others opinions

MaterArc commented 1 week ago

Like I said, it needs work! But it's definitely a start...

blazgocompany commented 1 week ago

I'm back.

Like I said, it needs work! But it's definitely a start...

What work does it need? If you are talking about other Scratch pages, can't I just add them in future PR's?

rgantzos commented 1 week ago

I'm back.

Like I said, it needs work! But it's definitely a start...

What work does it need? If you are talking about other Scratch pages, can't I just add them in future PR's?

I'm not sure about their exact thoughts for what it needs, but if there's further intended usage, then we don't want to ship any unfinished features.

blazgocompany commented 6 days ago

Ok I'll finish the home page styles by Monday.

blazgocompany commented 6 days ago

Ok. I finished the home page. Let me know if you have any suggestions. Also I can't test the whole thing at once. I test it commit by commit so if you can send me a screenshot of what it looks like that would be great 👍🏼

blazgocompany commented 6 days ago

Also, I was wondering how to use JavaScript in browser extensions. Is there anything different in browser extensions (especially for DOM manipulation)

MaterArc commented 6 days ago

Ok. I finished the home page. Let me know if you have any suggestions. Also I can't test the whole thing at once. I test it commit by commit so if you can send me a screenshot of what it looks like that would be great 👍🏼

Screenshot 2024-06-22 at 5 38 02 PM
rgantzos commented 5 days ago

The Scratch News white on light blue doesn't have a whole lot of contrast.

blazgocompany commented 5 days ago

Uh Oh.. That screenshot scared me. Fixed. Also couple questions:

blazgocompany commented 5 days ago

@callumjt's commit new desc is not exectly what I wanted. This is for the entire Scratch site. It is just not implemented yet. It is coming soon

callumjt commented 4 days ago

Uh Oh.. That screenshot scared me. Fixed.

Also couple questions:

  • How do I use JavaScript in browser extensions? Is there anything different in browser extensions (especially for DOM manipulation)?

Check the docs :), and i dont think there are any differences in dom manipulation, at least afaik

callumjt commented 4 days ago

@callumjt's commit new desc is not exectly what I wanted. This is for the entire Scratch site. It is just not implemented yet. It is coming soon

Ill change it later then

callumjt commented 4 days ago

From skimming through the editor file it seems like its a dark theme although doesnt this just contradict the home page? Im sure others would agree, but it should be consistent

blazgocompany commented 4 days ago

Yep. You're right. Ill think about it and get back.

blazgocompany commented 4 days ago

What do you think? Should we have the Light background for everything or have Dark or what? It kind of makes sense to have just the editor dark but its your choice. My suggestion is have everything Dark and Ill work to add a light mode.

rgantzos commented 4 days ago

What do you think? Should we have the Light background for everything or have Dark or what? It kind of makes sense to have just the editor dark but its your choice.

If this only affects the homepage, then we should count on it being light.

blazgocompany commented 4 days ago

No this is for the editor. My suggestion is have everything Dark and Ill work to add a light mode.

rgantzos commented 4 days ago

@blazgocompany Do you happen to have Discord?

blazgocompany commented 4 days ago

No

rgantzos commented 4 days ago

No

I've seen your codepen work- would you be interested in joining the developer team on @STForScratch/website-developers

blazgocompany commented 4 days ago

Sure

blazgocompany commented 3 days ago

Any updates here?

blazgocompany commented 1 day ago

@rgantzos @MaterArc @callumjt ?????

blazgocompany commented 1 day ago

Ok there u are. I'm like its been 3 days and nothings happend

blazgocompany commented 1 day ago

So here's what I need to know:

blazgocompany commented 1 day ago

@MaterArc what did you add at line 91?

MaterArc commented 1 day ago

So here's what I need to know:

  • Do you have any other suggestions for the homepage?
  • Does the background color of the orange box-content's look too dark?
  • Are we doing dark/light theme

I would suggest any/all of these

  1. Dark editor, Light everything else
  2. Dark Everything
  3. Light Everything
  4. NOT the opposite of 1

So here's what I need to know:

  • Do you have any other suggestions for the homepage?
  • Does the background color of the orange box-content's look too dark?
  • Are we doing dark/light theme

I would suggest any/all of these

  1. Dark editor, Light everything else
  2. Dark Everything
  3. Light Everything
  4. NOT the opposite of 1

I can answer bullets two and three right off the bat. The orange color looks fine to me, dark and light themes could be nice for customizability.

blazgocompany commented 1 day ago

@MaterArc Thank you.