STIXProject / python-stix

A Python library for parsing, manipulating, and generating STIX content.
http://stix.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
241 stars 88 forks source link

OrganisationalInfo seems incomplete #108

Open rpiazza opened 10 years ago

bworrell commented 10 years ago

@rpiazza - Are you referring to the CIQ Identity extension's OrganisationInfo element? Are there fields you need implemented?

rpiazza commented 10 years ago

Yes. The 3 I'm currently interested in are:

I might need more later

benjaminxscott commented 9 years ago

Is the extension's intent to be a complete implementation of CIQ? or a "best effort" one

From reference looks like there is Specification/Revenue , OrganisationInfo/NumberofEmployees and OrganisationInfo/IndustryCode

bworrell commented 9 years ago

The CIQ extension is being filled out on a case-by-case basis and not really intended to be an exhaustive implementation of the CIQ PartyType datatype (and supporting types). The currently defined fields are there mostly because they were asked for by community members or needed for specific use cases. I'm not sure if that answers your question :)

I think the three fields you referred to, @bschmoker, are the ones that @rpiazza was asking for.

rpiazza commented 9 years ago

I agree with @bworrell , I was not looking or a complete implementation. When I was working on the veris2stix converter, there were a few fields in the VERIS schema that fit naturally into CIQ, but they weren't implemented in python-stix.

Here is the relevant part of the VERIS schema:

"victim": { "additionalProperties": false, "properties": { "country": { "items": { "type": "string" }, "minItems": 1, "type": "array", "uniqueItems": true }, "employee_count": { "type": "string" }, "industry": { "maxLength":6, "minLength":2, "pattern":"\d{2}-?\d{0,4}", "type": "string" }, "locations_affected": { "type": "integer" }, "notes": { "minLength": 1, "type": "string" }, "region": { "items": { "type": "string", "maxLength":6, "minLength":6 }, "minItems": 1, "type": "array", "uniqueItems": true }, "revenue": { "additionalProperties": false, "minProperties": 1, "properties": { "amount": { "type": "integer" }, "iso_currency_code": { "type": "string" } }, "type": "object" },