refactor into report to close #235

STIXProject / stixproject.github.io

Source for the STIX Documentation site

http://stixproject.github.io

BSD 3-Clause "New" or "Revised" License

43 stars 18 forks source link

refactor into report to close #235 #246

Closed benjaminxscott closed 9 years ago

benjaminxscott commented 9 years ago

I had amended the commit, dcb77ff is the canonical one (should work properly on a merge)

johnwunder commented 9 years ago

xml is not really valid at all either

johnwunder commented 9 years ago

this should merge to stix-1.2, not master

benjaminxscott commented 9 years ago

@johnwunder If I'm reading 9315c52e4a9795d952baea55973b666c69042520 correctly, making dcb77ff valid was: add xmlns:report="http://stix.mitre.org/Report-1" and update to version = 1.2 ` Was that the changes?

johnwunder commented 9 years ago

IIRC it was:

xmlns:report=....
Re-order the Reports element to be at the end
Re-name Package_Intent => Intent
I also meant to switch the vocab from PackageIntentVocab-1.0 to ReportIntentVocab-1.0 but it looks like I forgot. It'll validate either way but only the latter is correct. Also I may have a merge error, looking into it now.

I've been using the 2.2.0 branch of STIX validator to validate things.