search

STMicroelectronics / STM32CubeF4

STM32Cube MCU Full Package for the STM32F4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
869 stars 418 forks source link

clear warning expression result unused when use ARMCC6 #12

Closed ZemingLiu closed 3 years ago

ZemingLiu commented 4 years ago

clear warning expression result unused when use ARMCC6

ALABSTM commented 4 years ago

Hi @ZemingLiu,

Thank you for this report. May I ask you whether you used the last STM32CubeF4 firmware available (i.e. v1.25.0)? If it is not the case, would you mind checking whether the issue still exists on the latest version delivered?

Thank you,

ZemingLiu commented 4 years ago

Hi @ZemingLiu,

Thank you for this report. May I ask you whether you used the last STM32CubeF4 firmware available (i.e. v1.25.0)? If it is not the case, would you mind checking whether the issue still exists on the latest version delivered?

Thank you,

Yes, use v1.25.0 HAL library

ALABSTM commented 4 years ago

Hi @ZemingLiu,

Thank you for your quick reply. Please allow me to introduce @bouattay from our development teams. He will take in charge checking the relevancy of what you reported and provide you with his feedback.

With regards,

bouattay commented 4 years ago

Hello ZemingLiu,

acked, return value of setup function will be fixed in next USB device Lib

Thanks, Aymen

ALABSTM commented 4 years ago

ST Internal Reference: 84540

ALABSTM commented 3 years ago

Hi @ZemingLiu,

I hope you are fine. This issue has been fixed in the frame of the STM32CubeF4 v1.26.0 published a couple of days ago. The implementation, however, is slightly different from your proposal as you can see below:

https://github.com/STMicroelectronics/STM32CubeF4/blob/d599a824dfe257bee2aeff403caf592da816b126/Middlewares/ST/STM32_USB_Device_Library/Core/Src/usbd_ctlreq.c#L288

Thank you again for your contribution. We are looking forward to receiving your future contributions.

With regards,