STMicroelectronics / STM32CubeF4

STM32Cube MCU Full Package for the STM32F4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
827 stars 409 forks source link

[ETH] Fixed errors in bit positions #125

Closed DedkovArtem closed 1 year ago

DedkovArtem commented 2 years ago

fixed multiple errors in bit positions in registers.

In version 1.26.2, the structure fields were assigned values already taking into account the bit position in the register. For example macinit.ZeroQuantaPause = ETH_ZEROQUANTAPAUSE_DISABLE; where #define ETH_ZEROQUANTAPAUSE_DISABLE 0x00000080U

in version 1.27.0, some fields of the structure are assigned the values 1 or 0. And when these fields are written to the register, the offset by the bit position is not taken into account. For example macDefaultConf.ZeroQuantaPause = DISABLE; where DISABLE=0U

ASELSTM commented 2 years ago

ST Internal Reference: 126335

ASELSTM commented 1 year ago

Hi @DedkovArtem,

Thank you for your contribution. This issue has been fixed in the frame of version v1.27.1 of the STM32CubeF4. Please allow me then to close this thread.

With regards,