search

STMicroelectronics / STM32CubeF4

STM32Cube MCU Full Package for the STM32F4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
871 stars 418 forks source link

HAL_RCC_GetSysClockFreq: Add conditional check for the value of pllm #154

Closed PwnVerse closed 1 year ago

PwnVerse commented 1 year ago

Check value of pllm in function HAL_RCC_GetSysClockFreq of stm32f4xx_hal_rcc.c:911

This is a pull request pertaining to the issue raised here. Feel free to review it and merge it.

RJMSTM commented 1 year ago

ST Internal Reference: 146728

RJMSTM commented 1 year ago

Hello @PwnVerse

Thank you again for having reported this point. It has been fixed in the frame of version 1.28.0 of this firmware.

With regards,

ALABSTM commented 1 year ago

Fixed in commit d5af56388ff037735ac99de39abf2b46f9921aa3

ALABSTM commented 1 year ago

Hi @PwnVerse,

Thank you for your proposal. A fix has just been published yet with a completely different implementation than yours, as you can see here. Hence, this pull-request cannot be merged as-is. Thank you for your comprehension.

Anyway, thank you for having drawn our attention to this point. We are looking forward to receiving future contributions from you.

With regards,

PwnVerse commented 10 months ago

Hi @PwnVerse,

Thank you for your proposal. A fix has just been published yet with a completely different implementation than yours, as you can see here. Hence, this pull-request cannot be merged as-is. Thank you for your comprehension.

Anyway, thank you for having drawn our attention to this point. We are looking forward to receiving future contributions from you.

With regards,

Can a CVE ID be assigned to this? It would help with faster security patch propagation. Thanks.