search

STMicroelectronics / STM32CubeF4

STM32Cube MCU Full Package for the STM32F4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
869 stars 418 forks source link

register keyword #27

Closed wmmc88 closed 3 years ago

wmmc88 commented 4 years ago

Describe the set-up

Describe the bug warning: ISO C++17 does not allow 'register' storage class specifier [-Wregister]

How To Reproduce

  1. Compile with -std=gnu++2a or -std=gnu++17

Additional context Ther warnings show in several different files including stm32f4xx_ll_usart.h, stm32f4xx_ll_tim.h, stm32f4xx_ll_adc.h, stm32f4xx_ll_rtc.h, etc. I believe the register keyword should just be removed as its been deprecated since C++11, removed since C++17 and compilers havent used it for a long long time. Would u accept a pr removing use of this keyword?

ARM also removed the use of the "register" keyword in cmsis: https://github.com/ARM-software/CMSIS_5/commit/f46ec37262bc4fd82b6c91d24198cc3b4a499fe3 https://github.com/ARM-software/CMSIS_5/issues/345

Relevant issue: https://github.com/ARMmbed/mbed-os/issues/12232

ASELSTM commented 4 years ago

Hi @wmmc88,

First of all we would like to thank you for your contribution.

Actually, this issue has already been reported within our GitHub repositories (STM32CubeH7/#15), we have already spotted the problem and fixed it internally. However, the fix has not been published yet. It is scheduled for next release.

With regards,

ASELSTM commented 4 years ago

ST Internal Reference: 84396

wmmc88 commented 4 years ago

Hi @wmmc88,

First of all we would like to thank you for your contribution.

Actually, this issue has already been reported within our GitHub repositories (STM32CubeH7/#15), we have already spotted the problem and fixed it internally. However, the fix has not been published yet. It is scheduled for next release.

With regards,

Is there a release schedule that you guys follow or do you know when the next release will be out?

ASELSTM commented 4 years ago

Hi @wmmc88,

Unfortunately, we cannot share an exact date of our next STM32CubeF4 release for the moment. We will keep you informed.

With regards,

ASELSTM commented 3 years ago

Hi @wmmc88,

I hope you are fine. The issue you reported has been fixed in the frame of version v1.26.0 of the STM32CubeF4 published recently on GitHub.

Thank you again for having reported.

With regards,