Missing struct member init in BSP LIS3DSH driver

STMicroelectronics / STM32CubeF4

STM32Cube MCU Full Package for the STM32F4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))

Other

869 stars 418 forks source link

Missing struct member init in BSP LIS3DSH driver #91

Closed kevinpt closed 2 years ago

kevinpt commented 3 years ago

There is a call to LIS3DSH_InterruptConfig() in lis3dsh.c in the BSP components that is missing an init value for State_Machine1_Interrupt. This is flagged for me by GCC with -Werror=uninitialized. I don't know what an appropriate init value should be for this but it should compile cleanly nonetheless.

https://github.com/STMicroelectronics/STM32CubeF4/blob/4aba24d78fef03d797a82b258f37dbc84728bbb5/Drivers/BSP/Components/lis3dsh/lis3dsh.c#L222

RKOUSTM commented 3 years ago

Hi @kevinpt,

Thank you for your report. It has been forwarded to our development teams. I will get to you as soon as they provide their feedback.

With regards,

RKOUSTM commented 3 years ago

Hi @kevinpt,

Thank you for your contribution. An internal tracker has been logged and a fix will be implemented and made available in the frame of a future release.

Thank you once again for your contribution.

With regards,

RKOUSTM commented 3 years ago

ST Internal Reference: 114019

RKOUSTM commented 2 years ago

Hi @kevinpt,

Thank you for your contribution. This issue has been fixed in the frame of version v1.27.0 of the STM32CubeF4 published recently. Please allow me then to close this thread.

Thank you again for your contribution.

With regards,