search

STMicroelectronics / STM32CubeF7

STM32Cube MCU Full Package for the STM32F7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
342 stars 197 forks source link

Basically all of the stm32f7xx_hal_eth.h macros are just copy-pasta'd from H7 and using H7 registers #101

Closed HTRamsey closed 7 months ago

HTRamsey commented 1 year ago

F7 registers != H7 registers

TOUNSTM commented 1 year ago

Hello @holden-zenith,

Thank you for this report. We will get back to you as soon as we analyze it further. This may take some time. Thank you for your comprehension.

With Regards,

TOUNSTM commented 1 year ago

Hello @holden-zenith,

I've tried to do an analysis on my own and I can't find the problem you mentioned. In order to enable a better analysis of this problem, could you please give us more details.

Thank you again for your contribution.

With regards,

HTRamsey commented 1 year ago

for example #define ETH_DMA_NORMAL_IT ETH_DMACIER_NIE There is no ETH_DMACIER_NIE in stm32f767xx.h, it is ETH_DMAIER_NISE.

TOUNSTM commented 11 months ago

ST Internal Reference: 169492

mek363 commented 7 months ago

Can someone clarify which macros are affected by this?

HTRamsey commented 7 months ago

I think this fix was merged

mek363 commented 7 months ago

@HTRamsey thanks, was it this commit? https://github.com/STMicroelectronics/stm32f7xx_hal_driver/commit/5af4f7192a9331d27e5e90feed5e7cebc3f1356c

Is there any explanation of what incorrect behavior we might see without this fix? Or would we see compile-time errors because the referenced defines are not found?

HTRamsey commented 7 months ago

Should just be compile-time errors because they were all referencing H7 registers.

ALABSTM commented 6 months ago

Fixed in commit 5ff42d9979458a6426d67783c8ea2b2c7baee8d6