search

STMicroelectronics / STM32CubeF7

STM32Cube MCU Full Package for the STM32F7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
320 stars 191 forks source link

ETH: Missing ETH_MACCR_CSTF in cmsis header and driver #115

Closed HTRamsey closed 5 months ago

HTRamsey commented 5 months ago

CSTF is mentioned in the documentation (taken from RM0410) but not provided in the cmsis header or eth driver. It is, however, correctly added to H7 as ETH_MACCR_CST. image

Also, HAL_ETH_SetMDIOClockRange is never called anywhere.

HTRamsey commented 5 months ago

Also a quick question, is ETH_MACDMAConfig supposed to configure to reset values or are these configurations just arbitrarily chosen? For example, RetryTransmission is disabled making RD high instead of its reset value of low. The H7 driver enables it by default, which leaves RD at its reset value of low.

TOUNSTM commented 5 months ago

Hello @HTRamsey,

Thank you for your contribution. You are absolutely right about this point. Actually, the point you raised has already been dealt and fixed internally. The fix will be made available soon.

With Regards,

TOUNSTM commented 5 months ago

ST Internal Reference: 143308

TOUNSTM commented 5 months ago

Fixed in 30b30b27616d01af3fa11e0ba1662500bb6b5b3a

TOUNSTM commented 5 months ago

Fixed in 0495bf0fda6f592b034a4267f8e7c7b816e4196e