search

STMicroelectronics / STM32CubeF7

STM32Cube MCU Full Package for the STM32F7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
322 stars 191 forks source link

Error in usbd_conf_template.c line 178. 'ep_addr' undeclared #37

Closed emielsteerneman closed 2 years ago

emielsteerneman commented 3 years ago

https://github.com/STMicroelectronics/STM32CubeF7/blob/master/Middlewares/ST/STM32_USB_Device_Library/Core/Src/usbd_conf_template.c

In this file, on line 178, the variable 'ep_addr' is used but undeclared.

ALABSTM commented 3 years ago

Hi @emielsteerneman,

Thank you for having reported this point. It will be logged into our internal database to be fixed. Indeed, the parameter should be dev_addr instead of ep_addr. It should be replaced in both lines below related to function USBD_LL_SetUSBAddress(). Thank you again.

With regards,

https://github.com/STMicroelectronics/STM32CubeF7/blob/08376dce1b404687e4a86b73077f396bccfc9cb5/Middlewares/ST/STM32_USB_Device_Library/Core/Src/usbd_conf_template.c#L171

https://github.com/STMicroelectronics/STM32CubeF7/blob/08376dce1b404687e4a86b73077f396bccfc9cb5/Middlewares/ST/STM32_USB_Device_Library/Core/Src/usbd_conf_template.c#L178

ALABSTM commented 3 years ago

ST Internal Reference: 99960

ALABSTM commented 3 years ago

Hi @emielsteerneman,

I hope you are fine. The point you have raised has been updated in the frame of v2.8.0 of the USB Device Library found in the stm32_mw_usb_device repository. Thank you again for your report.

With regards,

ALABSTM commented 2 years ago

Hi @emielsteerneman,

Back to you about this point. Unfortunately, there is no plan to integrate version v2.8.0 of the USB Device library. However, you can get the latest updates from the repository indicated above as all versions are backward compatible.

Please allow me to close this issue. Thank you for your comprehension and thank you again for having reported the point.

With regards,

emielsteerneman commented 2 years ago

@ALABSTM I do not understand. There is a bug in the code. It has been fixed in stm32_mw_usb_device six months ago, but is still present in the master branch to this day.

ALABSTM commented 2 years ago

Hi @emielsteerneman,

As mentioned before, unfortunately, our development teams have no plan to integrate the new USB Device library version to the STM32CubeF7 firmware, this one still supporting a previous library version. This is why this issue has been closed with the label "wontfix".

With regards,