ETH_UpdateDescriptor() uses ETH_RX_BUF_SIZE define instead of user supplied value - Githubissues

STMicroelectronics / STM32CubeF7

STM32Cube MCU Full Package for the STM32F7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))

Other

320 stars 191 forks source link

ETH_UpdateDescriptor() uses ETH_RX_BUF_SIZE define instead of user supplied value #93

Closed Maashau closed 4 months ago

Maashau commented 1 year ago

ETH_InitTypeDef has user supplied member RxBuffLen. In ETH_UpdateDescriptor() ETH_RX_BUF_SIZE is used instead: https://github.com/STMicroelectronics/STM32CubeF7/blob/6a3b9bb8d09839f365ba83a6cf5823ae5f5226db/Drivers/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_eth.c#L1234 https://github.com/STMicroelectronics/STM32CubeF7/blob/6a3b9bb8d09839f365ba83a6cf5823ae5f5226db/Drivers/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_eth.c#L1238

Also in ETH_DMARxDescListInit(): https://github.com/STMicroelectronics/STM32CubeF7/blob/6a3b9bb8d09839f365ba83a6cf5823ae5f5226db/Drivers/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_eth.c#L3000

This makes RxBuffLen cause confusion and makes it pretty useless as it has to be the same value as the define.

ASELSTM commented 11 months ago

ST Internal Reference: 157139

RJMSTM commented 4 months ago

Fixed in: 2770385