STMicroelectronics / STM32CubeG0

STM32Cube MCU Full Package for the STM32G0 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
165 stars 75 forks source link

LL Syscfg comments incorrectly identify COMP EXTI lines #37

Closed grantg012 closed 11 months ago

grantg012 commented 2 years ago

The comments in https://github.com/STMicroelectronics/STM32CubeG0/blob/master/Drivers/STM32G0xx_HAL_Driver/Inc/stm32g0xx_ll_system.h#L1021 incorrectly label COMP1 and COMP2 to use EXTI 21 and 22 respectively. As per the reference manual, they use EXTI 17 and 18.

Additional context If you have a first analysis or a patch proposal, thank you to share your proposal.

Screenshots image

ASELSTM commented 2 years ago

Hi @grantg012,

The comment are indeed incorrect. The EXTI lines should be updated as you have mentioned.

/**
-  * @brief  Check if Comparator 1 interrupt occurred or not (EXTI line 21).
+  * @brief  Check if Comparator 1 interrupt occurred or not (EXTI line 17).
  * @rmtoll SYSCFG_ITLINE12 SR_COMP1      LL_SYSCFG_IsActiveFlag_COMP1
  * @retval State of bit (1 or 0).
  */
/**
-  * @brief  Check if Comparator 2 interrupt occurred or not (EXTI line 22).
+  * @brief  Check if Comparator 2 interrupt occurred or not (EXTI line 18).
  * @rmtoll SYSCFG_ITLINE12 SR_COMP2      LL_SYSCFG_IsActiveFlag_COMP2
  * @retval State of bit (1 or 0).
  */
  */

With regards,

ASELSTM commented 2 years ago

ST Internal Reference: 133892

TOUNSTM commented 11 months ago

fixed in commit 9f4c4a1c1ee2a497eb94defee1525f8cf7100bd5