search

STMicroelectronics / STM32CubeG4

STM32Cube MCU Full Package for the STM32G4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
182 stars 98 forks source link

IS_OPAMP_POWERMODE() use legacy OPAMP_POWERMODE_NORMAL #26

Closed CanastraRF closed 2 years ago

CanastraRF commented 3 years ago

I download STM32CubeG4 V1.4.0

In stm32g4xx_hal_opamp.h is in IS_OPAMP_POWERMODE() the legacy value OPAMP_POWERMODE_NORMAL used.

#define IS_OPAMP_POWERMODE(POWERMODE) (((POWERMODE) == OPAMP_POWERMODE_NORMAL) || \
                                       ((POWERMODE) == OPAMP_POWERMODE_HIGHSPEED) )

But the current value are:

#define OPAMP_POWERMODE_NORMALSPEED   (0x00000000UL)         /*!< Output in normal mode */
#define OPAMP_POWERMODE_HIGHSPEED     OPAMP_CSR_HIGHSPEEDEN  /*!< Output in highspeed mode */

Please fix this ASAP ReFe

ASELSTM commented 3 years ago

Hi @CanastraRF,

The issue you pointed out is confirmed, an internal tracker has been logged and a fix will be implemented and made available in the frame of a future release. Thank you once again for your contribution.

With regards,

ASELSTM commented 3 years ago

ST Internal Reference: 103568

ALABSTM commented 2 years ago

Hi @CanastraRF,

I hope you are fine. The issue you reported has been fixed in the frame of version v1.5.0 of the STM32CubeG4 published recently on GitHub as you can see below. Thank you again for having reported.

https://github.com/STMicroelectronics/STM32CubeG4/blob/8580c58e6b0b8036d26806d43bdc115829781ab8/Drivers/STM32G4xx_HAL_Driver/Inc/stm32g4xx_hal_opamp.h#L337

https://github.com/STMicroelectronics/STM32CubeG4/blob/8580c58e6b0b8036d26806d43bdc115829781ab8/Drivers/STM32G4xx_HAL_Driver/Inc/Legacy/stm32_hal_legacy.h#L1006-L1007

With regards,

CanastraRF commented 2 years ago

Thank You for the fix