STMicroelectronics / STM32CubeH7

STM32Cube MCU Full Package for the STM32H7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
https://www.st.com/en/embedded-software/stm32cubeh7.html
Other
495 stars 303 forks source link

Add support for ADC LDO output voltage ready bit #187

Closed fivdi closed 1 year ago

fivdi commented 2 years ago

Revision V STM32H743 devices have an "ADC LDO output voltage ready bit" in the "ADC interrupt and status register". In the reference manual this bit is called LDORDY and it is bit 12 in the ADC_ISR register.

STM32CubeH7 V1.9.0 doesn't provide support for the LDORDY bit. For example, there are no defines for LDORDY in stm32h743xx.h and there is no low level functionality for accessing LDORDY in stm32h7xx_ll_adc.h

It would be good if support for the LDORDY bit in the ADC_ISR register was added to STM32CubeH7.

Initial tests with functions that I implemented myself for accessing the LDORDY bit in the ADC_ISR register indicate that the bit functions as expected with a WeAct Studio STM32H743 Core Board.

The same issue may exist for other STM32H7 devices.

RKOUSTM commented 2 years ago

Hi @fivdi,

Thank you for your contribution. An internal tracker has been logged and a fix will be implemented and made available in the frame of a future release.

Thank you once again for your contribution.

With regards,

RKOUSTM commented 2 years ago

ST Internal Reference: 117529.

fivdi commented 1 year ago

Thank you.

For anyone interested, support for the LDORDY bit in the ADC_ISR register was added to stm32h7xx_ll_adc.h with ADC_ISR_LDORDY and LL_ADC_IsActiveFlag_LDORDY(ADC_TypeDef *ADCx).

stm32h743xx.h was also appropriately modified.