Fix compiler warnings under -Wswitch-enum

STMicroelectronics / STM32CubeH7

STM32Cube MCU Full Package for the STM32H7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))

https://www.st.com/en/embedded-software/stm32cubeh7.html

Other

490 stars 302 forks source link

Fix compiler warnings under -Wswitch-enum #200

Closed radioflash closed 10 months ago

radioflash commented 2 years ago

By being explicit about cases that are treated as "default" in switch statements.

This does not change behavior at all, it only silences compiler warnings that may be very helpful in spotting programmer mistakes elsewhere.

Also added some comments about why those cases are handled as default/error.

(I did sign the CLA already)

ALABSTM commented 2 years ago

Hi @radioflash,

Thank you for this pull-request. We will get back to you with a feedback as soon as possible. Please excuse the delay it may take us sometimes to reply. Thank you for your comprehension.

With regards,

ASELSTM commented 2 years ago

ST Internal Reference: 122349

ALABSTM commented 10 months ago

Hi @radioflash,

I hope you are fine. Thank you again for this proposal. However, we cannot accept it.

Indeed, this would add more size to the code.
Moreover, it is specified in the release note of the STM32CubeH7 firmware that the supported mode is the "AC5-like warnings", as shown on the screenshot below.

In this case, please allow me to close this pull-request. Thank you for your comprehension and thank you again for your proposal.

With regards,