search

STMicroelectronics / STM32CubeH7

STM32Cube MCU Full Package for the STM32H7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
https://www.st.com/en/embedded-software/stm32cubeh7.html
Other
490 stars 302 forks source link

SPI45 PCLK clock source macros are mislabeled. #219

Closed iabdalkader closed 1 year ago

iabdalkader commented 2 years ago

Describe the bug SPI45 does Not have a PCLK1 clock source, it should PCLK2 (and D2PCLK2). You can see that in CubeMX, the first clock source in the MUX is PCLK2:

image

And also in any H7 reference manual (for example dm00176879 section 9.5.8 Figure 57) you can see SPI45 the only PCLK source available is PCLK2:

image

So RCC_SPI4CLKSOURCE_D2PCLK1 should be renamed to RCC_SPI4CLKSOURCE_D2PCLK2 and RCC_SPI45CLKSOURCE_PCLK1 to RCC_SPI45CLKSOURCE_PCLK2

I can send a PR to fix that, but not sure if you want to avoid breaking existing code, alternatively for backwards compatibility you might want to consider adding:

#define RCC_SPI45CLKSOURCE_PCLK2        RCC_SPI45CLKSOURCE_D2PCLK1
ASELSTM commented 2 years ago

ST Internal Reference: 130353

ASELSTM commented 1 year ago

Hi @iabdalkader,

The issue you reported has been fixed in the frame of version v1.11.0 of the STM32CubeH7 published on GitHub.

Thank you again for having reported.

With regards,