Duplicate volatile reads in interrupt handler for hal_timer

STMicroelectronics / STM32CubeL0

STM32Cube MCU Full Package for the STM32L0 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))

Other

103 stars 57 forks source link

Duplicate volatile reads in interrupt handler for hal_timer #19

Closed jrahlf closed 7 months ago

jrahlf commented 3 years ago

Similar to #17 , there are unnecessary duplicate volatile reads in the interrupt handler for the timer peripheral. __HAL_TIM_GET_FLAG is called several times inside the handler, each time the actual value is fetched due to volatile qualifier.

https://github.com/STMicroelectronics/STM32CubeL0/blob/a7b74aed35ecb7baeadeb16107aa8fddb6823589/Drivers/STM32L0xx_HAL_Driver/Src/stm32l0xx_hal_tim.c#L3560

As in #17, this likely affects all other device variants (F1/F3/F4...) as well.

ASELSTM commented 3 years ago

ST Internal Reference: 162350

ASELSTM commented 3 years ago

Hi @jrahlf,

Thank you for your contribution. This has been communicated to the development team. We will come back to you as soon as we get their feedback.

Thank you again for your contribution.

With regards,

TOUNSTM commented 7 months ago

Fixed in 9d7402e