STMicroelectronics / STM32CubeL1

Full Firmware Package for the STM32L1 series: HAL+LL drivers, CMSIS, BSP, MW, plus a set of Projects (examples and demos) running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits).
Other
37 stars 24 forks source link

stm32l151xc.h lacks definitions for channel 27 to 29 in ADC sample time register 1 #12

Closed celange closed 1 year ago

celange commented 2 years ago

Describe the set-up

Describe the bug

How To Reproduce

  1. Get STM32CubeL1 v1.10.3.

  2. Inspect section Bit definition for ADC_SMPR1 register in stm32l151xc.h starting at line 986. There are definitions for channel 20 to channel 26 only, channel 27, 28 an 29 are missing.

  3. Check RM0038 Reference Manual chapter 12.15.4 ADC sample time register 1 (ADC_SMPR1) The sample time can be configured for channel 20 to channel 29.

RKOUSTM commented 2 years ago

Hi @celange,

Thank you for your report. According to the datasheet DS8890, the STM32151xC has 25 channels. While the STM32L151xCA, STM32L151xD, STM32L152xCA, STM32L152xD, STM32L162xCA, STM32L162xD, STM32L151xE, STM32L151xDX, STM32L152xE, STM32L152xDX, STM32L162xE and STM32L162xDX have up to 40 channels.

However, the channel numbers are still inadequate compared to those mentioned in the CMSIS files for each device. Your report will be forwarded to our development team. We will get back to you as soon as we have more details.

Thank you again for your report.

With regards,

RKOUSTM commented 2 years ago

ST Internal Reference: 119154

HBOSTM commented 1 year ago

Hello @celange,

The fix has been implemented and is now available in the frame of the latest STM32CubeL1 package V1.10.4 release. This issue can be closed now. Thank you again for your contribution.

With Regards,