warning: 'static' is not at beginning of declaration

STMicroelectronics / STM32CubeL4

STM32Cube MCU Full Package for the STM32L4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))

Other

262 stars 153 forks source link

warning: 'static' is not at beginning of declaration #3

Closed cracked-machine closed 4 years ago

cracked-machine commented 4 years ago

The definition of USBH_HID_InterfaceDeInit has the static keyword in different order to the declaration and generates a compiler warning:

../CubeMX/L476_USBHost/Middlewares/ST/STM32_USB_Host_Library/Class/HID/Src/usbh_hid.c:247:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [build] 247 | USBH_StatusTypeDef static USBH_HID_InterfaceDeInit (USBH_HandleTypeDef *phost)

https://github.com/STMicroelectronics/STM32CubeL4/blob/f6877af03b5c8b666b3443f5295cf95ec9c0b15d/Middlewares/ST/STM32_USB_Host_Library/Class/HID/Src/usbh_hid.c#L247

Moving static to the start of the line fixes the warning.

ALABSTM commented 4 years ago

Hi Cracked-Machine,

Thank you for reporting this issue. Please let me introduce @bouattay from our development teams who will take in charge the issue.

In the meanwhile, you may have noticed that clicking the "New issue" button displays a template listing different details needed to better analyze issues. Would you mind providing them please (firmware revision, IDE, compiler, and their versions). Thank you in advance for you collaboration.

With regards,

bouattay commented 4 years ago

Hi ALABSTM,

The issue is already fixed in host lib release v3.3.3

Regards, Aymen

CCASTM commented 4 years ago

Hello cracked-machine, You can find this v3.3.3 version of the USB Host in the L4 FW Package v1.15.0 published this week Regards Christophe

cracked-machine commented 4 years ago

thanks

On Wed, 8 Jan 2020, 15:46 Christophe Cadoret, notifications@github.com wrote:

Hello cracked-machine, You can find this v3.3.3 version of the USB Host in the L4 FW Package v1.15.0 published this week Regards Christophe

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/STMicroelectronics/STM32CubeL4/issues/3?email_source=notifications&email_token=ABZ4GZF45CJWPUFG4MVOTZTQ4XYMHA5CNFSM4KCAPLLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIM75WY#issuecomment-572128987, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ4GZDE2NYGAJQT4P2FKVLQ4XYMHANCNFSM4KCAPLLA .

CCASTM commented 4 years ago

Hello Ali, I think that we can close this Issue Regards Christophe

ALABSTM commented 4 years ago

Hi Cracked-Machine,

The STM32CubeL4 v1.15.0 firmware package has been published today including the USB Host Library v3.3.3.

We do hope this new library revision addresses the issue you pointed out and would like to thank you once more for your interest and contribution. Please allow me to close this issue now.

With regards,