STMicroelectronics / STM32CubeL4

STM32Cube MCU Full Package for the STM32L4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
259 stars 151 forks source link

HAL MMC voltage range configuration #48

Closed dima-kapustin closed 2 years ago

dima-kapustin commented 2 years ago

L4 HAL Driver for MMC v1.7

Voltage rage selection allows byte mode only, i.e. MMC_LOW_VOLTAGE_RANGE or MMC_HIGH_VOLTAGE_RANGE.

Some eMMC cards require sector mode selection, i.g. eMMC_HIGH_VOLTAGE_RANGE or eMMC_LOW_VOLTAGE_RANGE, which are defined in stm32l4xx_hal_mmc.h.

I could not find a way to configure high voltage sector mode, i.e. eMMC_HIGH_VOLTAGE_RANGE.

If there is no such a way then a bug shall be filed, I assume.

RKOUSTM commented 2 years ago

Hi @dima-kapustin,

Thank you for reporting this point. Actually, this point has been discussed and fixed internally, before we receive your request. The fix will be available in a future release, very soon hopefully. The following update is proposed to indicate as argument that the sector mode is supported by the host:

In the hal_mmc.c file:

   #if defined (VDD_VALUE) && (VDD_VALUE <= 1950U)
-  #define MMC_VOLTAGE_RANGE               MMC_LOW_VOLTAGE_RANGE
+  #define MMC_VOLTAGE_RANGE               EMMC_LOW_VOLTAGE_RANGE
...
   #else
-  #define MMC_VOLTAGE_RANGE               MMC_HIGH_VOLTAGE_RANGE
+  #define MMC_VOLTAGE_RANGE               EMMC_HIGH_VOLTAGE_RANGE

In the hal_mmc.h file:

-  #define eMMC_HIGH_VOLTAGE_RANGE       0xC0FF8000U  /*!< High voltage in sector mode  */
+  #define EMMC_HIGH_VOLTAGE_RANGE       0xC0FF8000U  /*!< High voltage in sector mode  */
...
-  #define eMMC_LOW_VOLTAGE_RANGE         0xC0000080U  /*!< Low voltage in sector mode   */
+  #define EMMC_LOW_VOLTAGE_RANGE         0xC0000080U  /*!< Low voltage in sector mode   */

Thank you again for having reported.

With regards,

RKOUSTM commented 2 years ago

ST Internal Reference: 106981

RKOUSTM commented 2 years ago

Hi @dima-kapustin,

I hope you are fine. The issue you reported has been fixed in the frame of version v1.17.1 of the STM32CubeL4 published recently on GitHub. Thank you again for having reported.

With regards,