STMicroelectronics / STM32CubeL4

STM32Cube MCU Full Package for the STM32L4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
259 stars 151 forks source link

RCC_APB1ENR1_RTCAPBEN define missing from stm32l476xx.h #51

Closed lucasholzen closed 2 years ago

lucasholzen commented 2 years ago

Caution The current version of CMSIS (v5) is missing the define for the RTC APB1 clock enable. https://raw.githubusercontent.com/STMicroelectronics/STM32CubeL4/master/Drivers/CMSIS/Device/ST/STM32L4xx/Include/stm32l486xx.h

It should look more like:

define RCC_APB1ENR1_LCDEN_Pos(9U)

define RCC_APB1ENR1_LCDEN_Msk (0x1UL << RCC_APB1ENR1_LCDEN_Pos) /!< 0x00000200 /

define RCC_APB1ENR1_LCDEN RCC_APB1ENR1_LCDEN_Msk

// MISSING

define RCC_APB1ENR1_RTCAPBEN_Pos (10U)

define RCC_APB1ENR1_RTCAPBEN_Msk (0x1UL << RCC_APB1ENR1_RTCAPBEN_Pos) /!< 0x00000400 /

define RCC_APB1ENR1_RTCAPBEN RCC_APB1ENR1_RTCAPBEN_Msk

// END OF MISSING

define RCC_APB1ENR1_WWDGEN_Pos (11U)

define RCC_APB1ENR1_WWDGEN_Msk (0x1UL << RCC_APB1ENR1_WWDGEN_Pos) /!< 0x00000800 /

define RCC_APB1ENR1_WWDGEN RCC_APB1ENR1_WWDGEN_Msk

Currently you have to manually define the registry location for the clock (or add the defines in yourself).

ALABSTM commented 2 years ago

Hi @lucasholzen,

Thank you for this report. We will get back to you with a feedback as soon as possible. Please excuse the delay it may take us sometimes to reply. Thank you for your comprehension.

With regards,

ALABSTM commented 2 years ago

Hi @lucasholzen,

As you can see on the screenshot below from the RM0351, at page 255, "this bit is reserved for STM32L47x/L48x devices". Hence, it is normal that it has been defined in none of the corresponding CMSIS files.

image

Would you mind reviewing the reason you need to define it? Probably there is no need.

With regards,

lucasholzen commented 2 years ago

My apologies, I was having issues with RTC Alarm B at the time and they were unrelated to the CMSIS driver. I did not ending up having to define the bit at all.

ALABSTM commented 2 years ago

Hi @lucasholzen,

If I understood correctly, you overcame the issue you were facing. Glad to read that.

With regards,