search

STMicroelectronics / STM32CubeL4

STM32Cube MCU Full Package for the STM32L4 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
Other
264 stars 154 forks source link

es-wifi: why not creating a submodule ? #93

Open joelguittet opened 1 month ago

joelguittet commented 1 month ago

Hello,

The es-wifi driver is used twice here for the B-L475E-IOT01A and B-L4S5I-IOT01A and additionally in the X-CUBE-GNSS package at https://github.com/STMicroelectronics/x-cube-gnss1.

While it's not really a big library and so not a big issue, the most important is that they are all different!!! I created a PR on this repository to fix an UDP issue (see https://github.com/STMicroelectronics/STM32CubeL4/pull/92) but the X-CUBE-GNSS package as a similar one too.

Why not creating submodules when you have this kind of libraries ? Here for the es-wifi driver this is a perfect example where maintenance of this stuff will be greatly simplified.

Joel

ALABSTM commented 1 month ago

Hi @joelguittet,

Thank you for this proposal. Actually, replacing BSP drivers by submodules is already in the pipe. However, the es-wifi looks to be a particular case as it is not located under ./Drivers/BSP/Components.

I have first to check with our development teams. I will get back to you once I have their feedback.

With regards,

joelguittet commented 1 month ago

Hello @ALABSTM Awesome 👍 thanks for this feedback. Joel

ALABSTM commented 5 hours ago

ST Internal Reference: 190925